Skip to content

Fix core list command not returning latest available version #1409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2021

Conversation

silvanocerza
Copy link
Contributor

@silvanocerza silvanocerza commented Aug 24, 2021

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

Fixes a command and related gRPC function returning incorrect data.

  • What is the current behavior?

The core list command doesn't return the correct latest available version for outdated cores.

$ arduino-cli core list
ID           Installed Latest Name                                        
arduino:samd 1.8.10    1.8.10 Arduino SAMD Boards (32-bits ARM Cortex-M0+)
$ arduino-cli core list --updatable
ID           Installed Latest Name                                        
arduino:samd 1.8.10    1.8.10 Arduino SAMD Boards (32-bits ARM Cortex-M0+)

Same thing for the gRPC interface function.

  • What is the new behavior?

core list now correctly the latest available version of the listed cores.

$ arduino-cli core list
ID           Installed Latest Name                                        
arduino:samd 1.8.10    1.8.11 Arduino SAMD Boards (32-bits ARM Cortex-M0+)
$ arduino-cli core list --updatable
ID           Installed Latest Name                                        
arduino:samd 1.8.10    1.8.11 Arduino SAMD Boards (32-bits ARM Cortex-M0+)

Same thing for gRPC interface function.

Nope.

  • Other information:

Partly fixes #1401.


See how to contribute

@silvanocerza silvanocerza self-assigned this Aug 24, 2021
@silvanocerza silvanocerza requested a review from rsora August 24, 2021 13:49
@silvanocerza silvanocerza force-pushed the scerza/fix-board-list-latest branch 3 times, most recently from 7072e74 to 6944e02 Compare August 24, 2021 14:05
@silvanocerza silvanocerza force-pushed the scerza/fix-board-list-latest branch from 6944e02 to 39be740 Compare August 25, 2021 08:51
@silvanocerza silvanocerza merged commit 372b881 into master Aug 25, 2021
@silvanocerza silvanocerza deleted the scerza/fix-board-list-latest branch August 25, 2021 09:41
@rsora rsora added type: imperfection Perceived defect in any part of project topic: gRPC Related to the gRPC interface topic: core topic: CLI Related to the command line interface labels Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: CLI Related to the command line interface topic: gRPC Related to the gRPC interface type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

board search fails with old core and core list not show latest version
3 participants